Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3184: Inject xlink in mermaidAPI. #3185

Merged
merged 3 commits into from Jul 3, 2022
Merged

fix #3184: Inject xlink in mermaidAPI. #3185

merged 3 commits into from Jul 3, 2022

Conversation

sidharthv96
Copy link
Member

馃搼 Summary

Ensure xlink is added for all diagrams.

Resolves #3184

馃搹 Design Decisions

Removed individual implementations and added single point of injection in mermaidAPI.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

* origin/develop: (24 commits)
  Updated the release version to 9.1.4
  Better balance check
  chore(deps-dev): bump @commitlint/config-conventional (#3179)
  chore(deps-dev): bump lint-staged from 13.0.2 to 13.0.3 (#3177)
  chore(deps-dev): bump cypress from 10.1.0 to 10.2.0 (#3178)
  chore(deps-dev): bump @commitlint/cli from 17.0.2 to 17.0.3 (#3180)
  chore: update browsers list
  fix: typo for source
  fix: typo in cypress
  Add dev install section in contributing.md
  update doc typos/clarity (#3145)
  Update links to `mermaid.live` (#3163)
  fix #3019 Add word boundary to FK&PK. (#3168)
  Run testomatio only for PRs within org. (#3165)
  chore(deps): bump got from 11.8.3 to 11.8.5 (#3172)
  fix: De-duplicates dependencies (#3167)
  Updated allowed characters to accomodate fonts and rgba colors
  fix: Typo for documents and comments
  Sanitizsation of incoming variables that are added to the userStyles
  Only allowing a subset of characters in themeVariables
  ...
@sidharthv96 sidharthv96 self-assigned this Jun 28, 2022
@mmorel-35 mmorel-35 merged commit 5b15865 into develop Jul 3, 2022
@knsv knsv deleted the fix/3184 branch August 23, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xlink attribute is not set for all diagrams
2 participants