Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mgol's name in AUTHORS, add .mailmap #1100

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Conversation

mgol
Copy link
Contributor

@mgol mgol commented Nov 22, 2017

In this way mgol's past contribution is mapped correctly.

In this way mgol's past contribution is mapped correctly.
@mgol
Copy link
Contributor Author

mgol commented Nov 22, 2017

Test failures don't seem related to this PR.

@dead-horse
Copy link
Member

I think this AUTHORS list is generated from git log (https://github.com/koajs/koa/blob/master/package.json#L11)

@fl0w
Copy link
Contributor

fl0w commented Nov 22, 2017

This list was generated using git log .... So even if this gets merged as requested it'll be a recurring issue whenever AUTHORS is updated.

"authors": "git log --format='%aN <%aE>' | sort -u > AUTHORS"

@mgol
Copy link
Contributor Author

mgol commented Nov 22, 2017

@fl0w The command you pasted respects .mailmap per https://git-scm.com/docs/pretty-formats:

%aN': author name (respecting .mailmap, see git-shortlog[1] or git-blame[1])

So this shouldn't be an issue (and I see it taken into account locally).

@fl0w
Copy link
Contributor

fl0w commented Nov 22, 2017

Oh, today I learned. Then I'm +1 :)

@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #1100 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1100   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           5        5           
  Lines         371      371           
=======================================
  Hits          370      370           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841844e...74ffeb6. Read the comment docs.

@dead-horse dead-horse merged commit 9068316 into koajs:master Dec 24, 2017
@mgol mgol deleted the mailmap branch January 19, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants