Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint-config-koa #1105

Merged
merged 4 commits into from
Dec 24, 2017
Merged

Conversation

nickmccurdy
Copy link
Member

@codecov
Copy link

codecov bot commented Dec 11, 2017

Codecov Report

Merging #1105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1105   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           5        5           
  Lines         371      371           
=======================================
  Hits          370      370           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c3c73...829f30e. Read the comment docs.

@nickmccurdy
Copy link
Member Author

nickmccurdy commented Dec 11, 2017

It works well with the current versions of eslint plugins, but the latest versions of eslint-plugin-standard and its peerDependencies are also supported by eslint-config-koa. Do we want to merge now and shelve the package updates for later or would you like me to do it in this pull request?

@dead-horse dead-horse merged commit 53bea20 into koajs:master Dec 24, 2017
@nickmccurdy nickmccurdy deleted the use-eslint-config branch December 24, 2017 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants