Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run coverage using --runInBand, fixes #1109 #1141

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

fl0w
Copy link
Contributor

@fl0w fl0w commented Feb 9, 2018

Ref jestjs/jest#1874
Fixes #1109

The gist: Jest seems to be writing to cache from two different child processes. It's slower, but doesn't really affect Koa.

I'm expecting this to solve flaky travis tests

@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #1141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           5        5           
  Lines         372      372           
=======================================
  Hits          371      371           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e544012...3d27c82. Read the comment docs.

@nickmccurdy
Copy link
Member

Nice! It seems like the cron job has already been passing, does this fix some existing problem I'm not noticing or is this is a proactive change?

@dead-horse dead-horse merged commit 0923ef6 into koajs:master Feb 9, 2018
@fl0w
Copy link
Contributor Author

fl0w commented Feb 9, 2018

It’s a race condition apparently, and so until that issue is closed I’m thinking it’s safe to assume to use the fallback for now.

@fl0w fl0w deleted the coverage-travis branch February 14, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants