Fix tests #1170
Merged
Fix tests #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the error message was not tested at all. This change makes sure the error will actually be tested for.
`assert.doesNotThrow` does not provide any benefit since it will only catch errors and then rethrow in case of an error.
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 5 5
Lines 374 374
=======================================
Hits 373 373
Misses 1 1Continue to review full report at Codecov.
|
|
👍 thanks |
jonathanong
approved these changes
Apr 10, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in CITGM while improving
assert.throwsin Node.js. See nodejs/node#19867 for more information.The current tests never checked for the error message and instead, the error message would have been returned, just the same as if there would be no second argument at all.
This makes sure the error message is actually tested for.
Since I just looked at the code, I also added another commit to remove all
assert.doesNotThrowcalls. Those are always unnecessary. They do not provide any benefit since in case of an error it will just catch the error and rethrow.