fix: use non deprecated custom inspect #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
force-pushed
the
fix-util-inspect
branch
from
db512bc
to
30608fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
==========================================
+ Coverage 99.73% 99.73% +<.01%
==========================================
Files 5 5
Lines 373 383 +10
==========================================
+ Hits 372 382 +10
Misses 1 1
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Jun 4, 2018
dead-horse
reviewed
Jun 4, 2018
lib/response.js
Outdated
| module.exports[util.inspect.custom] = function() { | ||
| if (!this.res) return; | ||
| const o = this.toJSON(); | ||
| o.body = this.body; |
There was a problem hiding this comment.
can we move this line to this.toJSON() ?
|
I just pushed another commit to simplify it. That way it is always aligned, no matter if there are any changes to the actual inspection function. |
dead-horse
reviewed
Jun 6, 2018
lib/application.js
Outdated
| @@ -23,6 +23,7 @@ const http = require('http'); | |||
| const only = require('only'); | |||
| const convert = require('koa-convert'); | |||
| const deprecate = require('depd')('koa'); | |||
| const util = require('util'); | |||
There was a problem hiding this comment.
/home/travis/build/koajs/koa/lib/application.js: Duplicate declaration "util"
24 | const convert = require('koa-convert');
25 | const deprecate = require('depd')('koa');
> 26 | const util = require('util');
please fix this and good to merge. 👍
Custom inspection with the `inspect` property is deprecated and will not work in Node.js 11 anymore. This fixes it by using the custom inspect symbol where existent and falls back to the old style in case it does not exist.
BridgeAR
force-pushed
the
fix-util-inspect
branch
from
0ed1f0a
to
53daa01
Compare
|
Rebased and force pushed. |
|
Ping @dead-horse |
dead-horse
approved these changes
Jun 25, 2018
|
Should we backport this to 1.x as well perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom inspection with the
inspectproperty is deprecated and willnot work in Node.js 11 anymore. This fixes it by using the custom
inspect symbol where existent and falls back to the old style in case
it does not exist.