Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify processes in the getter request.protocol #1203

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Simplify processes in the getter request.protocol #1203

merged 1 commit into from
Jun 7, 2018

Conversation

initial-wu
Copy link
Contributor

  • Assignment to proxy before the if block is unnecessary

  • When proto is falsy then assigned 'http', calling split(...) on the string is unnecessary

@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #1203 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
- Coverage   99.73%   99.73%   -0.01%     
==========================================
  Files           5        5              
  Lines         374      373       -1     
==========================================
- Hits          373      372       -1     
  Misses          1        1
Impacted Files Coverage Δ
lib/request.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d42500...658a8c6. Read the comment docs.

@fengmk2 fengmk2 merged commit 77a4cfb into koajs:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants