Lazily initialize request.accept
#1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
+ Coverage 99.73% 99.73% +<.01%
==========================================
Files 5 5
Lines 383 384 +1
==========================================
+ Hits 382 383 +1
Misses 1 1
Continue to review full report at Codecov.
|
dead-horse
reviewed
Jun 25, 2018
lib/request.js
Outdated
| * @return {Object} | ||
| * @api public | ||
| */ | ||
| get accept() { |
There was a problem hiding this comment.
maybe you should add set accept() to avoid breaking change.
There was a problem hiding this comment.
I've pushed another commit to this PR.
dead-horse
reviewed
Jun 25, 2018
lib/request.js
Outdated
| * @api public | ||
| */ | ||
| set accept(obj) { | ||
| return this._accept = obj; |
fl0w
reviewed
Jun 25, 2018
lib/context.js
Outdated
| @@ -194,6 +194,7 @@ delegate(proto, 'request') | |||
| .access('query') | |||
| .access('path') | |||
| .access('url') | |||
| .access('accpet') | |||
There was a problem hiding this comment.
thx for reminding, i should have run a test
|
Added some test cases and reorganized the commits. @fl0w @dead-horse |
dead-horse
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To save memory consumption.