comment & cov: Fix comment & approve cov #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xtx1130
commented
Jul 2, 2018
xtx1130
commented
- fix comment for api
- ignore useless else cov branch
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 383 383
======================================
Hits 383 383
Continue to review full report at Codecov.
|
dead-horse
reviewed
Jul 2, 2018
| @@ -280,6 +280,7 @@ module.exports = { | |||
| */ | |||
|
|
|||
| get URL() { | |||
| /* istanbul ignore else */ | |||
There was a problem hiding this comment.
Istanbul makes else as a default branch, even though you don't write else. So coverage test will cover not-exist else as coverage
dead-horse
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.