Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: cache content type's result #1218

Merged
merged 1 commit into from
Jul 11, 2018
Merged

perf: cache content type's result #1218

merged 1 commit into from
Jul 11, 2018

Conversation

dead-horse
Copy link
Member

No description provided.

@dead-horse dead-horse requested a review from fengmk2 July 11, 2018 09:36
@dead-horse
Copy link
Member Author

improve ~3% performance.

  • before

image

  • after

image

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #1218 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1218   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           5       5           
  Lines         391     391           
======================================
  Hits          391     391
Impacted Files Coverage Δ
lib/response.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162a5b3...608e66e. Read the comment docs.

@fengmk2
Copy link
Member

fengmk2 commented Jul 11, 2018

Great job!

@fengmk2 fengmk2 merged commit c6b8782 into master Jul 11, 2018
@fengmk2 fengmk2 deleted the cache-calculate-type branch July 11, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants