perf: avoid stringify when set header #1220
Conversation
lib/response.js
Outdated
| if (Array.isArray(val)) val = val.map(String); | ||
| else val = String(val); | ||
| // maybe we can drop support of undefined in the next major version | ||
| if (val === undefined) val = 'undefined'; |
There was a problem hiding this comment.
other type of values will be stringify in res.setHeader
There was a problem hiding this comment.
res.getHeader will broken change after this change.
There was a problem hiding this comment.
Sets a single header value for headers object. If this header already exists in the to-be-sent headers, its value will be replaced. Use an array of strings here to send multiple headers with the same name. Non-string values will be stored without modification. Therefore, request.getHeader() may return non-string values. However, the non-string values will be converted to strings for network transmission.
|
about ~3% performance improve. -before
|
Codecov Report
@@ Coverage Diff @@
## master #1220 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 391 391
======================================
Hits 391 391
Continue to review full report at Codecov.
|
No description provided.