response.attachment append a parameter: options from contentDisposition #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1240 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 391 391
======================================
Hits 391 391
Continue to review full report at Codecov.
|
|
can you add a test case for this to avoid later changes modified this feature. |
added 2 commits
September 21, 2018 12:15
|
@dead-horse thanks, already done! |
fl0w
suggested changes
Sep 21, 2018
There was a problem hiding this comment.
Please also update docs at https://github.com/koajs/koa/blob/master/docs/api/response.md#responseattachmentfilename
Otherwise LGTM
test/response/attachment.js
Outdated
| @@ -48,3 +48,138 @@ describe('ctx.attachment([filename])', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| // reference [content-disposition test case](https://github.com/jshttp/content-disposition/blob/master/test/test.js) | |||
There was a problem hiding this comment.
I wouldn't make this comment md-style
|
Ok, I will do it two days later. |
|
@fl0w already done! |
dead-horse
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response.attachment require content-disposition, and content-disposition supports option parameter to make some settings, so i hope attachment can also support it.
thanks !