Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated docs for throw() to pass status as first param. #1268

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

WaleedAshraf
Copy link
Contributor

@WaleedAshraf WaleedAshraf commented Oct 29, 2018

Closes: #1261

I have updated comments/docs to use status only as the first param.
Let me know if we should also remove number type from the second param of throw() function.

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #1268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1268   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           5       5           
  Lines         393     393           
======================================
  Hits          393     393
Impacted Files Coverage Δ
lib/context.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0e0d6...572740c. Read the comment docs.

@WaleedAshraf
Copy link
Contributor Author

@fl0w Ping!

@dead-horse
Copy link
Member

thanks!

@dead-horse dead-horse merged commit 88b92b4 into koajs:master Nov 1, 2018
@WaleedAshraf WaleedAshraf deleted the issue-1261 branch November 1, 2018 11:34
*
* See: https://github.com/jshttp/http-errors
*
* Note: `stats` should only be passed as the first parameter.
Copy link
Contributor

@fl0w fl0w Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stats is misspelled, fixed in #1269 since already merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants