test: fix end after end #1374
Merged
test: fix end after end #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1374 +/- ##
======================================
Coverage 100% 100%
======================================
Files 4 4
Lines 377 379 +2
======================================
+ Hits 377 379 +2
Continue to review full report at Codecov.
|
dead-horse
reviewed
Aug 19, 2019
dead-horse
reviewed
Aug 23, 2019
ronag
commented
Aug 23, 2019
dead-horse
approved these changes
Aug 23, 2019
|
@Trott: I think we've fixed this in koa. Can we get another CITGM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a broken test which is cause failure in the Node test suite (nodejs/node#28666).