Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rest params for request/response .is #1393

Merged
merged 1 commit into from
Oct 14, 2019
Merged

use rest params for request/response .is #1393

merged 1 commit into from
Oct 14, 2019

Conversation

tinovyatkin
Copy link
Contributor

Using rest params and validation/concatenating logic is built-in into type-is
Also fixes JSDoc declaration

@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #1393 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1393   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           4       4           
  Lines         382     377    -5     
======================================
- Hits          382     377    -5
Impacted Files Coverage Δ
lib/request.js 100% <100%> (ø) ⬆️
lib/response.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c1593...53e7622. Read the comment docs.

@dead-horse dead-horse merged commit ef5c43b into koajs:master Oct 14, 2019
@tinovyatkin tinovyatkin deleted the use-spread branch October 14, 2019 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants