Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support writableEnded #1402

Merged
merged 1 commit into from
Oct 15, 2019
Merged

support writableEnded #1402

merged 1 commit into from
Oct 15, 2019

Conversation

tinovyatkin
Copy link
Contributor

@tinovyatkin tinovyatkin commented Oct 15, 2019

Add support for documented since Node >= 12.9 response.writableEnded property alongside undocumented response.finished used currently.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1402 into master will increase coverage by 0.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1402      +/-   ##
=========================================
+ Coverage   99.36%    100%   +0.63%     
=========================================
  Files           4       4              
  Lines         474     478       +4     
  Branches      124     124              
=========================================
+ Hits          471     478       +7     
+ Partials        3       0       -3
Impacted Files Coverage Δ
lib/response.js 100% <100%> (+0.63%) ⬆️
lib/request.js 100% <0%> (ø) ⬆️
lib/application.js 100% <0%> (+1.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f96829...1c1f322. Read the comment docs.

@dead-horse dead-horse merged commit f155785 into koajs:master Oct 15, 2019
@tinovyatkin tinovyatkin deleted the support-writable-ended branch October 15, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants