app.silent option to turn off err logging

[tejasmanohar]

Solves #447

// cc participants- @jonathanong @tj @cesarandreu

[tj]

lgtm. I guess this sort of crosses over into the logging discussions we had somewhere else too

[tejasmanohar]

@tj hm, somewhere else as in #447 or elsewhere? (sorry, pretty new to koa)

[tj]

I think it's scattered a bit, some in #367, and #219 is somewhat related. I'll leave this open for a little if anyone else wants to give some feedback but it works for me! thanks man

cc @koajs/owners

[tejasmanohar]

alrighty.

are we going to consider this a breaking change? i guess it does change what logs when and based on what... so kinda breaks the existing API. but then again, it is for logging so meh.

[travisjeffery]

Works for me too. I'm okay wither way w.r.t. to versioning, but based on expierence with other projects people tend to complain a lot even if you change logging and don't follow semver strictly.

[tejasmanohar]

@travisjeffery yeah, i think a major version would be a good idea... like 1.1

[tj]

Since it's just test related I think it would be fine, unless we leave that 'test' == check in until 2.x, doesn't really hurt

[tejasmanohar]

@tj Ah ok, you're right- would you like me to add the 'test'' env check back in AFTER the this.silent check? that would make it a non-breaking change.

[tejasmanohar]

i.e.

if (this.silent) return;
if ('test' == this.env) return;

so codebases relying on the 'test' env to not log won't be affected by this change. in v2, we can remove the 'test' env check and make people use the silent option? @tj

[tj]

sounds great! maybe throwing in a comment so we remember to deprecate it later // DEPRECATE (v2) or something

[tejasmanohar]

done- 6c19c41. yay for semver!

[fengmk2]

LGTM.