fix: add named arrow function for request and response handlers #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,15 +125,18 @@ module.exports = class Application extends Emitter { | |||
|
|
|||
| callback() { | |||
| const fn = compose(this.middleware); | |||
| const self = this; | |||
jonathanong
requested changes
Sep 15, 2016
fengmk2
force-pushed
the
named-functions-for-2.x
branch
from
ddf594b
to
8db28b1
Compare
fengmk2
changed the title
fengmk2
force-pushed
the
named-functions-for-2.x
branch
from
8db28b1
to
9afa847
Compare
fengmk2
commented
Oct 19, 2016
| @@ -128,13 +128,16 @@ module.exports = class Application extends Emitter { | |||
|
|
|||
| if (!this.listeners('error').length) this.on('error', this.onerror); | |||
|
|
|||
| return (req, res) => { | |||
| const handleRequest = (req, res) => { | |||
There was a problem hiding this comment.
@jonathanong "named arrow function" back
Current coverage is 100% (diff: 100%)@@ v2.x #805 diff @@
==================================
Files 4 4
Lines 418 420 +2
Methods 80 80
Messages 0 0
Branches 100 100
==================================
+ Hits 418 420 +2
Misses 0 0
Partials 0 0
|
|
named arrow function
|
o i c. i'm thinking maybe when we actually release koa v2, we only support node >= 8 since that's where |
|
@jonathanong Its a nice idea |
|
going to merge this and only support node 7.6+ :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #804