Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return middleware chain promise from callback() #848

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

PlasmaPower
Copy link
Contributor

The v2.x version of #847, see there for more details.

@codecov-io
Copy link

codecov-io commented Oct 28, 2016

Codecov Report

Merging #848 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #848   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         425    425           
  Branches      101    101           
=====================================
  Hits          425    425
Impacted Files Coverage Δ
lib/application.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188c096...913bab6. Read the comment docs.

@PlasmaPower
Copy link
Contributor Author

I'm going to rebase this - it'll be very helpful in rewriting a test, so I hope it gets merged soon.

@PlasmaPower
Copy link
Contributor Author

PlasmaPower commented Mar 1, 2017

Rebased! Let me know if anything still needs done before merging. As for testing, my new jest test suite will use this feature in a test. Also, I'm not sure this is complicated enough to need its own test.

@bttmly
Copy link

bttmly commented Mar 1, 2017

🎉 excellent! @jonathanong -- think we can get this merged soon? Also, I'm going to experiment a bit on some patterns for mounting a Koa app inside a Connect-style app and would be happy to contribute some docs about it once I have an approach that feels right.

@PlasmaPower PlasmaPower changed the title Return middleware chain promise from callback() (@next) Return middleware chain promise from callback() Mar 7, 2017
@PlasmaPower
Copy link
Contributor Author

Rebased again. Anything blocking merge?

@jonathanong jonathanong merged commit e6539e1 into koajs:master Mar 8, 2017
@bttmly
Copy link

bttmly commented Mar 8, 2017

Awesome! Thanks for pushing this through @PlasmaPower @jonathanong. If there is interest I'm happy to contribute some docs on how to properly embed Koa w/in existing Connect-style app and how to do an incremental migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants