-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return middleware chain promise from callback()
#848
Conversation
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 425 425
Branches 101 101
=====================================
Hits 425 425
Continue to review full report at Codecov.
|
I'm going to rebase this - it'll be very helpful in rewriting a test, so I hope it gets merged soon. |
Rebased! Let me know if anything still needs done before merging. As for testing, my new jest test suite will use this feature in a test. Also, I'm not sure this is complicated enough to need its own test. |
🎉 excellent! @jonathanong -- think we can get this merged soon? Also, I'm going to experiment a bit on some patterns for mounting a Koa app inside a Connect-style app and would be happy to contribute some docs about it once I have an approach that feels right. |
The v2.x version of 8836cd3 on master.
callback()
(@next)callback()
Rebased again. Anything blocking merge? |
Awesome! Thanks for pushing this through @PlasmaPower @jonathanong. If there is interest I'm happy to contribute some docs on how to properly embed Koa w/in existing Connect-style app and how to do an incremental migration. |
The v2.x version of #847, see there for more details.