remove unused app.name #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2.x #899 +/- ##
===================================
Coverage 100% 100%
===================================
Files 4 4
Lines 421 421
Branches 100 100
===================================
Hits 421 421Continue to review full report at Codecov.
|
cyjake
reviewed
Feb 14, 2017
| @@ -110,7 +110,6 @@ app.listen(3000); | |||
| Application settings are properties on the `app` instance, currently | |||
| the following are supported: | |||
|
|
|||
| - `app.name` optionally give your application a name | |||
There was a problem hiding this comment.
I think the convention might already been established. What is the point of removing it?
|
a minimal interface better |
|
👍 for this. anyone else? |
|
👍 I don't remember what it's for haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app.nameis mentioned in the documentation, but doesn't seem to have any semantic meaning.Application instances are not frozen and as far as I can tell there's no reason to force people to use
namespecifically (people may want to useid/machineId, etc., or even better, don't rely on koa app's namespace to pass this information)