New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point multiplication is wrongly implemented as field multiplication #7

Open

trstovall opened this issue Jun 12, 2018 · 1 comment

trstovall commented Jun 12, 2018 •

edited

tiny-ECDH-c/ecdh.c

Line 933 in 4218dcd

/* 6) (x,y) = (u1 * G) + (u2 * public) */

ecdsa_verify is using gf2field_mul instead of gf2point_mul.

The text was updated successfully, but these errors were encountered:

Owner

kokke commented Jun 13, 2018

Hi @trstovall and thanks for pointing out this issue :) That's a nice catch.

The user zcode1 has already made me aware of that problem in #6 (comment) - but I haven't found time to fix it in the source code yet.

However it is not the only issue with the ECDSA code it seems, because signing / verification still doesn't work properly, at least in my testing....

I will keep this issue open until I commit changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment