Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add package-lock.json file (npm run build broken) #1757

Closed
Balearica opened this issue May 8, 2024 · 2 comments
Closed

Request: add package-lock.json file (npm run build broken) #1757

Balearica opened this issue May 8, 2024 · 2 comments

Comments

@Balearica
Copy link

Balearica commented May 8, 2024

At present, cloning this repo, running npm install, and then npm run build produces the following error.

node_modules/@types/markdown-it/lib/index.d.ts:151:33 - error TS2694: Namespace 'LinkifyIt' has no exported member 'LinkifyIt'.

151     readonly linkify: LinkifyIt.LinkifyIt;
                                    ~~~~~~~~~

This appears to be caused by a recent change to a dependency of a dependency, so is not the fault of this package. However, this requires troubleshooting by users because this repo lacks a package-lock.json file. It looks like package-lock.json is explicitly excluded in the .gitignore file.

https://github.com/konvajs/konva/blob/master/.gitignore#L14

The package-lock.json file is intended to avoid exactly this sort of situation, and allow users to replicate a working environment with minimal effort, regardless of dependency updates. Therefore, I think the maintainers should consider removing this line from the .gitignore file and adding this file to make installation easier going forward.

@Balearica Balearica changed the title Request: add package-lock.json file Request: add package-lock.json file (npm install broken) May 8, 2024
@Balearica
Copy link
Author

For other users experiencing this, adding the dependency @types/markdown-it@13.0.8 to package.json appears to resolve. This root cause of this issue is discussed here.

DefinitelyTyped/DefinitelyTyped#69355

@Balearica Balearica changed the title Request: add package-lock.json file (npm install broken) Request: add package-lock.json file (npm run build broken) May 8, 2024
@lavrton
Copy link
Member

lavrton commented May 15, 2024

I am not really sure if it is very useful for the repo.
But the issue highlighted another issue, that typescript shouldn't check node_modules at all. Just added that skip.

@lavrton lavrton closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants