-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: add support for other read-it-later services (omnivore,shiori) #10406
Comments
If it works sufficiently similar maybe the Wallabag plugin can be generalized. I'd be less enthused about having another plugin that's extremely similar but different, anyway. ;-) |
A bit dissapointing https://github.com/omnivore-app/omnivore#how-to-deploy-to-your-own-server |
Looking around some more, neither Omnivore nor Shiori export EPUB files. Wallabag definitely does and I'm guessing that the current KOReader plugin just lets wallabag do the hard conversion work and it downloads the result. Adding Omnivore/Shiori support would make the plugin much more complex because it would have to do all that conversion itself. I don't have the time or motivation to implement this, so I'll just stick with wallabag for now ^^' |
A PR for epub generation is close to being merged to shiori. So hopefully it becomes realistic once that happens. |
Creating an EPUB in KOReader isn't much work — or rather, the work's already been done before. That being said, in those linked Shiori API docs I don't even see how to get the content, just the URL? Now that could complicate matters significantly, given how authentication can also be an important part of these systems, cf. |
I start working on shiori ebook Generation to link that to KOReader later. For now, shiori is under heavy API refactor on go-shiori/shiori#497. |
Other than actually getting content in any form at all I don't see anything obviously missing in the API docs. For PDF you'd generally want to download the actual PDF instead of some text extracted EPUB. |
Edit would ideally also include read status though; I don't see that listed. |
There is some discussion about how should handle read status go-shiori/shiori#343 For now, we have PDF on disk, but not return in API. I plan to return actual PDF file when I'm starting work on update API for eink device. But it is on hold until go-shiori/shiori#497 done. |
@Monirzadeh: you'll need to populate |
@pazos note: i add shiori in https://github.com/koreader/koreader/blob/master/frontend/ui/elements/reader_menu_order.lua after wallabag too, but it is not work |
Your guess is good. If you want to place the menu entry at a fixed position you need to edit the menu file and ignore sorting hint. Editing reader menu order will affect the menu of the reader. You need to do ir also on the file manager menu order. |
Omnivore (GitHub) is an open source read-it-later service similar to wallabag, which KOReader already has support for. I'd like to see support added for Omnivore as well; its UI is much more pleasant than wallabag's and they have a promising roadmap.
If this would be welcome as a PR, I'll take a look when I have time over the summer.
The text was updated successfully, but these errors were encountered: