adapt description to should style #19
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajalt
referenced
this pull request
in ajalt/kotlintest
Jul 13, 2018
The current string shrink algorithm generates candidates by dropping single characters from the end of the input. This doesn't produce the smallest case, since it doesn't drop characters from the start of the string. It is also linear on the size of the input, so it requires a potentially large number of tries to reach the result it does produce.
This PR changes to algorithm to bisect the input string from both directions, producing a minimal output in log n tries.
As an example of the current behavior, the test:
`forAll { it: String -> !it.contains("#") }`
produces output like this:
```
Attempting to shrink failed arg DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) e|Gr+ tri7jw{
Shrink #1: <empty string> pass
Shrink #2: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) e|Gr+ tri7 fail
Shrink #3: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) e|Gr+ fail
Shrink #4: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) fail
Shrink #5: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQx fail
Shrink #6: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k fail
Shrink #7: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x, fail
Shrink #8: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B* fail
Shrink #9: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn fail
Shrink #10: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2 fail
Shrink #11: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M# fail
Shrink #12: DPn CPQ7hBAY&LP;7MxPtN^Oy\$ pass
Shrink #13: DPn CPQ7hBAY&LP;7MxPtN^Oy\$F pass
Shrink #14: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz pass
Shrink #15: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz; pass
Shrink #16: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M pass
Shrink #17: aaaaaDPn CPQ7hBAY&LP;7MxPtN^Oy\$ pass
Shrink #18: aaaaDPn CPQ7hBAY&LP;7MxPtN^Oy\$F pass
Shrink #19: aaaDPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz pass
Shrink #20: aaDPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz; pass
Shrink #21: aDPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M pass
Shrink result => DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#
```
This is 21 attempts to produce a string 32x longer than optimal.
The new algorithm produces output like this:
```
Attempting to shrink failed arg t ^j>t\o,x3?eb9#F'>g>vGQ-N}nkx
Shrink #1: <empty string> pass
Shrink #2: t ^j>t\o,x3?eb9 pass
Shrink #3: #F'>g>vGQ-N}nkx fail
Shrink #4: #F'>g>vG fail
Shrink #5: #F'> fail
Shrink #6: #F fail
Shrink #7: # fail
Shrink result => #
```
This is only 7 tries, and produces the correct output of `"#"`
sksamuel
pushed a commit
that referenced
this pull request
Jul 15, 2018
The current string shrink algorithm generates candidates by dropping single characters from the end of the input. This doesn't produce the smallest case, since it doesn't drop characters from the start of the string. It is also linear on the size of the input, so it requires a potentially large number of tries to reach the result it does produce.
This PR changes to algorithm to bisect the input string from both directions, producing a minimal output in log n tries.
As an example of the current behavior, the test:
`forAll { it: String -> !it.contains("#") }`
produces output like this:
```
Attempting to shrink failed arg DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) e|Gr+ tri7jw{
Shrink #1: <empty string> pass
Shrink #2: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) e|Gr+ tri7 fail
Shrink #3: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) e|Gr+ fail
Shrink #4: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQxU+!) fail
Shrink #5: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k<}QQx fail
Shrink #6: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x,L;6&k fail
Shrink #7: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B*w,1x, fail
Shrink #8: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn18+B* fail
Shrink #9: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2yEcNn fail
Shrink #10: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#EC\M2 fail
Shrink #11: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M# fail
Shrink #12: DPn CPQ7hBAY&LP;7MxPtN^Oy\$ pass
Shrink #13: DPn CPQ7hBAY&LP;7MxPtN^Oy\$F pass
Shrink #14: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz pass
Shrink #15: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz; pass
Shrink #16: DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M pass
Shrink #17: aaaaaDPn CPQ7hBAY&LP;7MxPtN^Oy\$ pass
Shrink #18: aaaaDPn CPQ7hBAY&LP;7MxPtN^Oy\$F pass
Shrink #19: aaaDPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz pass
Shrink #20: aaDPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz; pass
Shrink #21: aDPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M pass
Shrink result => DPn CPQ7hBAY&LP;7MxPtN^Oy\$Fz;M#
```
This is 21 attempts to produce a string 32x longer than optimal.
The new algorithm produces output like this:
```
Attempting to shrink failed arg t ^j>t\o,x3?eb9#F'>g>vGQ-N}nkx
Shrink #1: <empty string> pass
Shrink #2: t ^j>t\o,x3?eb9 pass
Shrink #3: #F'>g>vGQ-N}nkx fail
Shrink #4: #F'>g>vG fail
Shrink #5: #F'> fail
Shrink #6: #F fail
Shrink #7: # fail
Shrink result => #
```
This is only 7 tries, and produces the correct output of `"#"`
myuwono
pushed a commit
that referenced
this pull request
Jan 24, 2024
modify `containExactlyInAnyOrder` so that it explicitly prints out when
count of duplicates is different, such as:
```
shouldThrow<AssertionError> {
listOf(1, 2, 2, 3).shouldContainExactlyInAnyOrder(listOf(1, 2, 3, 3))
}.shouldHaveMessage(
"""
Collection should contain [1, 2, 3, 3] in any order, but was [1, 2, 2, 3]
CountMismatches: Key="2", expected count: 1, but was: 2, Key="3", expected count: 2, but was: 1
""".trimIndent()
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.