Replace timeout + timeUnit with Duration #30
Conversation
|
Awesome. I might change the release version to 1.3 rather than 2.0 as that's still a major version. I know that's not strictly semver but it seems to be what most JVM projects do, eg Scala, Spark, Akka etc. What do you think? |
|
I think that many projects don't use versioning properly. The version numbers lose there expressiveness. And today version numbers are actually pretty cheap ;-) Let's follow semantic versioning. Have you noticed that the build fails? I try to fix it (what is not optimal without beeing able to compile it under windows). |
|
Yes I noticed, I will attempt a fix in a minute. I'm on windows atm and On 15 June 2016 at 20:43, Christian Helmbold notifications@github.com
|
|
I tried to fix it and created another pull request. #31 I'm in blind flight mode without a compiler ;-) |
|
Can't merge it - conflicts. On 15 June 2016 at 20:56, Christian Helmbold notifications@github.com
|
* replace timeout and timeoutUnit with duration * add changelog
provide more details when `shouldExistInOrder` fails. For instance,
print out "Predicate number 1 did not match", as shown in the following
example:
```
"fail with clear message" {
shouldThrowAny {
listOf(1, 2).shouldExistInOrder(
{ i: Int -> i < 2 },
{ i: Int -> i < 2 }
)
}.message shouldBe "[1, 2] did not match the predicates [(kotlin.Int) -> kotlin.Boolean, (kotlin.Int) -> kotlin.Boolean] in order. Predicate at index 1 did not match."
}
```
---------
Co-authored-by: Emil Kantis <emil.kantis@protonmail.com>
The changelog style follows https://github.com/olivierlacan/keep-a-changelog . #29