Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withEdgecases annihilates shrinkers #3812

Closed
viluon opened this issue Dec 22, 2023 · 0 comments · Fixed by #3922
Closed

withEdgecases annihilates shrinkers #3812

viluon opened this issue Dec 22, 2023 · 0 comments · Fixed by #3922
Labels
bug 🐛 Issues that report a problem or error in the code. property-testing 📏 Related to the property testing mechanisms within the testing framework.

Comments

@viluon
Copy link

viluon commented Dec 22, 2023

Which version of Kotest are you using 5.8.0

withEdgecases builds a new Arb without forwarding the shrinker. Arbs like Arb.list(Arb.long()).withEdgecases() should still shrink.
@Kantis Kantis added the property-testing 📏 Related to the property testing mechanisms within the testing framework. label Dec 24, 2023
@sksamuel sksamuel added the bug 🐛 Issues that report a problem or error in the code. label Mar 10, 2024
sksamuel added a commit that referenced this issue Mar 10, 2024
@sksamuel
withEdgecases should keep shrinker #3812
919b074
@sksamuel sksamuel mentioned this issue Mar 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 10, 2024
@sksamuel
withEdgecases should keep shrinker #3812 (#3922)
9ae2a62 
Fixes #3812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Issues that report a problem or error in the code. property-testing 📏 Related to the property testing mechanisms within the testing framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

withEdgecases should keep shrinker #3812 kotest/kotest
3 participants
@Kantis @sksamuel @viluon