Warning stops test execution

[helmbold]

If I run all tests of the KotlinTest project, the execution (in IntelliJ 2016.1.3) stops with 109 of 110 tests. It appears the message:

[WARN] When comparing doubles consider using tolerance, eg: a shouldBe b plusOrMinus c

[sksamuel]

I don't think the warn is anything to do with that, because that's just being emitted when I test plusOrMinus in DoubleMatchersTest. I get something similar, but all tests pass. I think perhaps the count is just off.

[sksamuel]

Ah the issue is just that there is an ignored test in ConfigTest. It's there just to make sure the dsl doesn't change and for a visible check. I'm not sure how to check that an ignored test didn't actually run.

[helmbold]

How does JUnit gets the number of tests? Maybe ignored tests can be subtracted there.

[sksamuel]

That's certainly easy enough to do, but then it doesn't appear in the list.
What do you think is better.

On 28 June 2016 at 10:59, Christian Helmbold notifications@github.com
wrote:

How does JUnit gets the number of tests? Maybe ignored tests can be
subtracted there.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#43 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAtZGmR076iRLPOm2yRB-FvSzKrCZOOKks5qQPCTgaJpZM4I-ETJ
.

[helmbold]

It is good to see (and count) ignored tests.However there is some difference between ignored JUnit tests and ignored KotlinTest tests.

JUnit counts all tests and ignored tests:

KotlinTest doesn't count ignored tests:

I have no idea how to do it, but I'd prefer the JUnit behavior and view.

[sksamuel]

Agreed. I'll figure it out while you're doing the config stuff.

On 28 June 2016 at 11:40, Christian Helmbold notifications@github.com
wrote:

It is good to see (and count) ignored tests.However there is some
difference between ignored JUnit tests and ignored KotlinTest tests.

JUnit counts all tests and ignored tests:
[image: test count in JUnit]
https://camo.githubusercontent.com/0d7cee037b162a624cf0b2138529ce471d1ce36e/687474703a2f2f692e696d6775722e636f6d2f30596f59716b372e706e67

KotlinTest doesn't count ignored tests:
[image: test count with KotlinTest]
https://camo.githubusercontent.com/750846fc38b6d436f0ec97cad81034caa56bbde7/687474703a2f2f692e696d6775722e636f6d2f4b303775526a672e706e67

I have no idea how to do it, but I'd prefer the JUnit behavior and view.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#43 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAtZGlQl0TudSLHP9MYq6voAkW-x2PgCks5qQPoagaJpZM4I-ETJ
.

[sksamuel]

Sorted