Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyframe with multiple properties are not inserted correctly #61

Open
wyze opened this issue Jun 18, 2021 · 1 comment · May be fixed by #62
Open

Keyframe with multiple properties are not inserted correctly #61

wyze opened this issue Jun 18, 2021 · 1 comment · May be fixed by #62
Labels
bug Something isn't working

Comments

@wyze
Copy link

wyze commented Jun 18, 2021

Description

keyframes with multiple properties are not inserted correctly.

Reproduction

https://codesandbox.io/s/otion-keyframes-multiple-properties-3d98i

Expected behavior

keyframes should output correct style rules like the following:

@keyframes _1sk3gu2 {0%{margin:5% 0;width:90%}50%{margin:18% 0;width:60%}100%{margin:5% 0;width:90%}}

Actual behavior

keyframes output is the following:

@keyframes _1sk3gu2 {0%{margin:5% 0width:90%}50%{margin:18% 0width:60%}100%{margin:5% 0width:90%}}

Notice the missing semicolons.

Environment

System:

  • OS: macOS 10.15.7
  • CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  • Memory: 398.66 MB / 16.00 GB
  • Shell: 5.8 - /usr/local/bin/zsh

Binaries:

  • Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
  • Yarn: 1.22.10 - /usr/local/bin/yarn
  • npm: 6.14.12 - ~/.nvm/versions/node/v14.16.1/bin/npm
  • Watchman: 2021.06.07.00 - /usr/local/bin/watchman

Browsers:

  • Chrome: 91.0.4472.106
  • Firefox: 85.0.2
  • Safari: 14.0.1

npmPackages:

  • otion: ^0.6.2 => 0.6.2
@wyze wyze added the bug Something isn't working label Jun 18, 2021
@phiberber
Copy link

Just encountered the same bug, what is the reason of this still being open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants