Fixes the circular JSON TypeError #197
Conversation
…SON conversion + adds tests
ThinkTankShark
changed the title
Bugfix/circular json
|
Thanks @ThinkTankShark, but unfortunately, this cannot be merged. We need an alternative solution that doesn't use external dependencies. |
|
Hi @krisk. Thanks for the response. I didn't realize that I left that external dependency in the code.... It was unnecessary and I removed it. Please let me know if you I need to do anything else to help out. Great module, super useful. |
|
Will this fix be added now that the external dependency has been removed? |
|
@ThinkTankShark Merge conflicts ... |
|
Thank you @valera-rozuvan! Fixed. 👍 |
|
Can we merge this please? :) |
|
Would you be interested in software that automatically finds TypeErrors caused by corner cases like circular structures? I am building Fuzz Stati0n to do that (free for OSS) - please take a look and consider signing up for our newsletter to keep in touch. |
|
hi @krisk, could you merge this PR please? Regards |
|
@krisk any updates on this? |
|
@krisk Would you please let us know if this is going to get approved / merged anytime soon or should we close it? I would be more than happy to fix the branch conflicts if it's approved. Thanks |
|
@krisk 🙏 |
|
just another monthly checkin on this issue |
|
April check-in, how's this going? |
|
May-be? |
|
@krisk Can you please update everyone on this PR? Appreciate it. |
|
I missed July... my bad. Can we please get this merged for August?! |
|
Well, this was embarrassing on my part. My apologies on the unforgivably long delay, @ThinkTankShark! There were several conflicts, as the library had been updated a while back, so I incorporated your codebase instead (as merging was slightly nightmarish). Credit given 100% to you though, and noted in v3.3.1 release notes |
No description provided.