Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocolVersion used by the predictor #3674

Open
Csehpi opened this issue May 9, 2024 · 0 comments
Open

protocolVersion used by the predictor #3674

Csehpi opened this issue May 9, 2024 · 0 comments

Comments

@Csehpi
Copy link

Csehpi commented May 9, 2024

Hi community,

I am trying to understand how protocolVersion is used by the predictor and I would like to ask some help from you.

Here is a little example:

apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  name: sklearn-from-uri
spec:
  predictor:
    model:
      modelFormat:
        name: sklearn
      protocolVersion: v1
      runtime: kserve-sklearnserver
      storageUri: "gs://kfserving-examples/models/sklearn/1.0/model"

The doc says: Protocol version to use by the predictor (i.e. v1 or v2 or grpc-v1 or grpc-v2)
https://kserve.github.io/website/latest/reference/api/#serving.kserve.io/v1beta1.PredictorExtensionSpec

When pod, service, etc. is ready then I am able to call both V1 and V2 endpoints. Is this the expected behaviour?

Thanks,
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant