-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider use of System.IO.Enumeration #33
Comments
This seems like a good suggestion. I would be open to discussing an implementation/API for this and greatly appreciation any contributions. |
This seems interesting but until these APIs are available in .NET standard I don't think it make sense for this project at this time. Thanks |
Makes sense. It's expected in.NET Standard 2.1: |
I am subscribed to that PR 😄 I will keep an eye on it. |
@danmosemsft I was looking at the code for the System.IO.Enumeration APIs and I noticed that there are bits of code like:
As far as I can tell those allow usage from .NET Framework 4.7.2. Is that correct? If I wanted to use the file system enumeration API in .NET Framework 4.7.2 would I need to add a package for Microsoft.IO.Redist? |
I think so - looks like it's in nuget. Since our focus is.NET Core if you found a bug that was specific to.NET Framework we might not be able to fix it, but it's open source and as far as I know it would work fine. @JeremyKuhne owns this - Jeremy any known issues with the package on.NET Framework? |
@kthompson No known issues. :) That package is specifically for 4.7.2. Let me know if you have any problems with it. |
@JeremyKuhne the only thing I noticed is that all of the |
@kthompson that is by design as they are different types. The library doesn't include everything in |
@JeremyKuhne Ok. I don't think it will be a major issue for users of this library on .NET Framework to use |
In .NET Core 2.1 there's a "advanced" file system enumeration API
https://blogs.msdn.microsoft.com/jeremykuhne/2018/03/09/custom-directory-enumeration-in-net-core-2-1/ that is faster and more customizable.
Perhaps this would be interesting to use if available, especially since .NET Core itself does not yet have advanced globbing functionality.
The text was updated successfully, but these errors were encountered: