Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to register messages when message parsing #530

Merged
merged 3 commits into from
Apr 24, 2022

Conversation

ktr0731
Copy link
Owner

@ktr0731 ktr0731 commented Apr 21, 2022

This fixes #529.
In Protocol Buffers v2, we must register messages explicitly by using protoregistry.

@ktr0731 ktr0731 self-assigned this Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #530 (09d8a94) into master (72b34a2) will decrease coverage by 0.16%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   80.16%   80.00%   -0.17%     
==========================================
  Files          57       57              
  Lines        3846     3860      +14     
==========================================
+ Hits         3083     3088       +5     
- Misses        536      542       +6     
- Partials      227      230       +3     

@ktr0731 ktr0731 merged commit 155e704 into master Apr 24, 2022
@ktr0731 ktr0731 deleted the fix-message-registration branch April 24, 2022 17:15
ktr0731 added a commit that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom message is not shown on status details
1 participant