Compile warnings

[DoumanAsh]

While porting I noticed quite high amount of compile warnings.

What is your stance on it?
Should it be eventually fixed?

[eiennohito]

What kind of warnings?

There could be signed-unsigned conversion/comparison warnings over the place.

g++/clang builds on macos/linux are (mostly) warning-free with -Wall.

One place is the usage of tmpfile in tests, but it is safe and actually should be that way.
Let's setup a windows CI and look around the warnings.

[DoumanAsh]

One of these warnings are signed-unsigned conversion yes. It seems to be on by default for Windows.

We can I guess tune warnings for windows too.
And maybe turn of "unsafe" function warnings and then take a look.

[eiennohito]

Ah, unsafe Windows CRT functions. I see.
Need to setup a windows environment and see the warnings for myself as it seems.

[eiennohito]

On warnings:

(I will update this list)

Ignore:

• Everything from jumanpp_rnn_legacy
• C4141 (inline used more than once)