Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a Jumanpp version into comments when analyzing #80

Open
kzinmr opened this issue Jan 30, 2018 · 2 comments
Open

Write a Jumanpp version into comments when analyzing #80

kzinmr opened this issue Jan 30, 2018 · 2 comments

Comments

@kzinmr
Copy link

kzinmr commented Jan 30, 2018 •
edited

In Juman, SID header like # S-ID:5-5 is converted with its version like # S-ID:5-5 JUMAN:7.01.
Jumanpp_v2 just passes it without the version like # S-ID:5-5.
As a result, downstream KNP's header breaks like # S-ID:5-5 ���c�� KNP:4.18-CF1.1 DATE:2018/01/30 SCORE:-11.52755.
@kzinmr
Copy link
Author

kzinmr commented Jan 30, 2018 •
edited

I avoid this issue by manually appending pseudo-version into every SID header of input files like # S-ID:5-5 JUMAN++:2.0.0 (ugly hack).

@eiennohito
Copy link
Contributor

This is a KNP bug I think...

Suggestion: add flag --version-comment=<off|append|prepend> with the default state being off.
Otherwise we either append or prepend current version (what is the current version is more complex question).

If a comment of an input sentence was # S-ID:5-5, then we would output:

  • # S-ID:5-5 for off
  • # Jumanpp:2.0.0 S-ID:5-5 for prepend
  • # S-ID:5-5 Jumanpp:2.0.0 for append

@eiennohito eiennohito changed the title invalid comment format Write a Jumanpp version into comments when analyzing Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eiennohito @kzinmr