Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ability to add new dictionary words to already trained model (aka user dictionary) #94

Open
eiennohito opened this issue Jun 26, 2018 · 0 comments

Comments

@eiennohito
Copy link
Contributor

eiennohito commented Jun 26, 2018

Actual ngram features depend on field entry pointers, so we can't change them. We can completely rebuild trie index and dictionary entry table.

Logic should be:

  1. Do the step 1 of dictionary import (compute unique column values with frequencies)
  2. Read the present string storages and remove already stored values from the step 1 results.
  3. Append new values to each string storage
  4. Rebuild entry table.
  5. Rebuild index.

Probably, we should implement the initial import as append to an initially empty dictionary to have only one implementation of csv dictionary import logic.

The open question is what should we do with full duplicates.
Should the import logic perform the full deduplication of the dictionary entries in addition to the current logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant