You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I enable NoSuperfluousConcatenationFixer, this is the resulting code:
printf("\"%s\";\"%s\";\"%s\"\r\n", ...$line);
So the fixer concatenated the strings, but as a side effect introduced ugly escaping due to the double quotes now being used. I can work around this in my codebase, but it would be even better to have a setting for the fixer which controls if concatenations are retained if the type of quotes would have to be changed. In this case, such a setting would leave the code as-is.
(Apart from that: great tool.)
The text was updated successfully, but these errors were encountered:
So far, I haven’t even tried to understand how php-cs-fixer or your fixers work. Therefore, this would probably be a challenge for me, but at least I could try. But it will take a while, especially as I know that I won’t have time for this within the next six to eight weeks.
On a code base I work on, I have this line:
printf('"%s";"%s";"%s"'."\r\n", ...$line);
When I enable
NoSuperfluousConcatenationFixer
, this is the resulting code:printf("\"%s\";\"%s\";\"%s\"\r\n", ...$line);
So the fixer concatenated the strings, but as a side effect introduced ugly escaping due to the double quotes now being used. I can work around this in my codebase, but it would be even better to have a setting for the fixer which controls if concatenations are retained if the type of quotes would have to be changed. In this case, such a setting would leave the code as-is.
(Apart from that: great tool.)
The text was updated successfully, but these errors were encountered: