Experimenting with adapting the linkerd labels module for general use #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight copy + factor out 2 std imports Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
|
I was about to open an issue, but then I've found this PR that I think it is implementing what I was looking for! I was looking for something similar to this go package in order to filter on client-side a list of pods given a label_selector. If you need review/inputs let me know 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavy WIP. The linkerd module is good and has nice patterns, but it is not super focused to fitting our interfaces, plus it does not have a way to serialize the query string for the API so am trying to write that plus make the builder interface on expression more ergonomic. Stashing here as WIP, will maybe get to it on the weekend.
ListParamsListParams::labels_fromtaking aSelectorExpression(done 1)LabelsrevampResourceExt::labels()to something we can compare againstLabelsaltogether? commented out for now (arc use seems unnecessary for us)OperatorandValues? now there's the awkward representable case ofIn/NotInbut empty values...