Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile #1490

Closed
Masber opened this issue May 11, 2024 · 3 comments
Closed

Can't compile #1490

Masber opened this issue May 11, 2024 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Masber
Copy link

Masber commented May 11, 2024

Current and expected behavior

cargo check throws the following error

error[E0308]: mismatched types
   --> /home/msopena/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kube-runtime-0.87.2/src/finalizer.rs:141:31
    |
141 |                         path: finalizer_path.clone(),
    |                               ^^^^^^^^^^^^^^^^^^^^^^ expected `Pointer`, found `String`

error[E0308]: mismatched types
   --> /home/msopena/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kube-runtime-0.87.2/src/finalizer.rs:144:68
    |
144 |                     PatchOperation::Remove(RemoveOperation { path: finalizer_path }),
    |                                                                    ^^^^^^^^^^^^^^ expected `Pointer`, found `String`

error[E0308]: mismatched types
   --> /home/msopena/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kube-runtime-0.87.2/src/finalizer.rs:159:31
    |
159 |                         path: "/metadata/finalizers".to_string(),
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Pointer`, found `String`

error[E0308]: mismatched types
   --> /home/msopena/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kube-runtime-0.87.2/src/finalizer.rs:163:31
    |
163 |                         path: "/metadata/finalizers".to_string(),
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Pointer`, found `String`

error[E0308]: mismatched types
   --> /home/msopena/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kube-runtime-0.87.2/src/finalizer.rs:173:31
    |
173 |                         path: "/metadata/finalizers".to_string(),
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Pointer`, found `String`

error[E0308]: mismatched types
   --> /home/msopena/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kube-runtime-0.87.2/src/finalizer.rs:177:31
    |
177 |                         path: "/metadata/finalizers/-".to_string(),
    |

Possible solution

No response

Additional context

No response

Environment

Client Version: v1.22.13
Server Version: v1.22.13

Configuration and features

kube = { version = "0.87.2", features = ["kube-client", "kube-runtime", "derive", "rustls-tls", "ws"] }
k8s-openapi = { version = "0.20.0", features = ["v1_26"] }

Affected crates

kube-core, kube-client, kube-derive, kube-runtime

Would you like to work on fixing this bug?

None

@Masber Masber added the bug Something isn't working label May 11, 2024
@clux
Copy link
Member

clux commented May 11, 2024

Probably due to #1486
Try upgrading upgrading your jsonpatch dep.

@clux
Copy link
Member

clux commented May 11, 2024

unrelated, but a FYI:

kube = { version = "0.87.2", features = ["kube-client", "kube-runtime", "derive", "rustls-tls", "ws"] }

the feature names we expose in Cargo.toml are not the crate names, that line should be:

kube = { version = "0.87.2", features = ["client", "runtime", "derive", "rustls-tls", "ws"] }

as per https://kube.rs/features/ . the implicit crate features will probably go away at some point.

@clux
Copy link
Member

clux commented May 19, 2024

Going to assume this is resolved for you. LMK if not.

@clux clux closed this as completed May 19, 2024
@clux clux added the duplicate This issue or pull request already exists label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants