You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When you define a LoadBalancerClass via env or cli flag kube-vip only reconciles Service objects with this LoadBalancerClass.
This is expected behaviour and should stay like that.
The problem is when you have kube-vip running without a LoadBalancerClass defined, it also reconciles Services with a LoadBalancerClass. This would lead to unexpected behaviour as it could announce IPs which it should not.
e.g.
Ingress controllers without a specific IngressClass set, only reconcile Ingresses without a IngressClass and ignore all Ingresses which have such IngressClass defined.
To Reproduce
Steps to reproduce the behavior:
Install kube-vip with svc_enable and the mode you like but without LoadBalancerClassName set
Create 2 Services
# a normal Service without a loadbalancerclassapiVersion: v1kind: Servicemetadata:
name: defaultspec:
externalTrafficPolicy: Localports:
- name: httpnodePort: 31690port: 80protocol: TCPtargetPort: http
- name: httpsnodePort: 32093port: 443protocol: TCPtargetPort: httpsselector: {}sessionAffinity: Nonetype: LoadBalancerstatus:
loadBalancer:
ingress:
- ip: 10.0.0.0
Expected behavior
The second service from the example above should not be reconciled by kube-vip but rather be skipped.
Screenshots
Environment (please complete the following information):
OS/Distro: Ubuntu 20.04
Kubernetes Version: v1.27.13
Kube-vip Version: v0.8.0
The text was updated successfully, but these errors were encountered:
Cellebyte
changed the title
[LoadBalancerClass] Better defaulting for Service objects without it.
[LoadBalancerClass] Better defaulting for Service objects without
May 14, 2024
Cellebyte
changed the title
[LoadBalancerClass] Better defaulting for Service objects without
[LoadBalancerClass] Better defaulting for Service objects
May 14, 2024
Describe the bug
When you define a LoadBalancerClass via
env
or cli flag kube-vip only reconcilesService
objects with thisLoadBalancerClass
.This is expected behaviour and should stay like that.
The problem is when you have kube-vip running without a
LoadBalancerClass
defined, it also reconcilesServices
with aLoadBalancerClass
. This would lead to unexpected behaviour as it could announce IPs which it should not.e.g.
Ingress controllers without a specific
IngressClass
set, only reconcile Ingresses without aIngressClass
and ignore allIngresses
which have suchIngressClass
defined.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The second service from the example above should not be reconciled by kube-vip but rather be skipped.
Screenshots
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: