You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces new behavior for LoadBalancer Class Name service filtering. With this new implementation only services that have LB class name set to the value configured in kube-vip (LoadBalancerClassName flag) will be processed. This is consistent with implementation in e.g. MetalLB or with how the ingress classes behave.
However this might be a braking change, so it is implemented (for now) as an option. 'Legacy' behavior is a default and can be disabled by setting LoadBalancerClassLegacyHandling config flag to false. In one of next releases this could become a default setting, and then legacy behavior could be removed altogether.
Hi @thebsdbox, I am not really sure. I've just tried to play with the tests a bit, but I see 2 issues:
I've tried to add LoadbalancerClass to the existing tests, just to check if those would pass with default kube-vip.io/kube-vip-class class, but it seems that v0.9.0 of kube-vip-cloud-provider discards any service which has LoadbalancerClass set. Would need to try with current main as it seems some additional controller for loadbalancer classes was added. As service has no loadbalancer IP assigned by cloud-provider, it is discarded by kube-vip as well and the test fails.
I can't see any clear way of determining if service was processed or discarded by kube-vip (other than reading logs, obviously :D). I've tried checking ip neighbour on the kind nodes, but I am not sure if this is a proper way to do this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new behavior for LoadBalancer Class Name service filtering. With this new implementation only services that have LB class name set to the value configured in kube-vip (
LoadBalancerClassNameflag) will be processed. This is consistent with implementation in e.g. MetalLB or with how the ingress classes behave.However this might be a braking change, so it is implemented (for now) as an option. 'Legacy' behavior is a default and can be disabled by setting
LoadBalancerClassLegacyHandlingconfig flag tofalse. In one of next releases this could become a default setting, and then legacy behavior could be removed altogether.Fixes #851