Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add image build vars to backend Makefiles #10724

Closed
gmfrasca opened this issue Apr 22, 2024 · 2 comments
Closed

[feature] Add image build vars to backend Makefiles #10724

gmfrasca opened this issue Apr 22, 2024 · 2 comments

Comments

@gmfrasca
Copy link
Member

Feature Area

/area backend

What feature would you like to see?

I would like to be able to simply run make image_XYZ while doing development work, which would use my preferred image build executable and publish to an image tag that I have defined; right now the images built are hardcoded to use docker, and publish to a hardcoded name and tag.

What is the use case or pain point?

Backend make image_XYZ commands are hardcoded to use the docker executable, and write to a hardcoded image name (w/ no tag, therefore always defaulting to latest). This also means if developers have multiple 'branches' of work ongoing they must remember to re-tag previously built images or risk overwriting old ones. It would be nice if the Makefile included a mechanism to override this, as a small QoL improvement.

Is there a workaround currently?

To work on multiple parallel work items, developers need to either re-tag built images or manually run image build commands which is a bit of an annoyance.


Love this idea? Give it a 👍.

@rimolive
Copy link
Member

/assign @gmfrasca

@gmfrasca
Copy link
Member Author

Fixed by #10725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants