Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Relax python_requires in setup.py #10738

Open
AndersBennedsgaard opened this issue Apr 24, 2024 · 0 comments
Open

[sdk] Relax python_requires in setup.py #10738

AndersBennedsgaard opened this issue Apr 24, 2024 · 0 comments

Comments

@AndersBennedsgaard
Copy link

AndersBennedsgaard commented Apr 24, 2024

Environment

  • KFP version: 2.1.0 (not relevant)
  • KFP SDK version: 2.7.0
  • All dependencies version:
    kfp                      2.7.0
    kfp-pipeline-spec        0.3.0
    kfp-server-api           2.0.5
    

Steps to reproduce

I tried to install kfp using Poetry, where I've set the allowed Python versions to python = "^3.11.0". However, this results in an version solving failed error since 3.13.0 is allowed in that range, but isn't allowed by kfp:

python_requires='>=3.7.0,<3.13.0',

As new minor versions of Python should be backwards compatible, there is no real reason for setting an upper limit to the Python version to <3.13.0.

Expected result

poetry add kfp doesn't return an error, since python_requires='>=3.7.0' is used

As a workaround I can set kfp = { version = "^2.7.0", python = ">=3.7,<3.13.0" } to force Poetry to figure out the highest allowed Python version, but we shouldn't have to do this.

Materials and Reference


Impacted by this bug? Give it a 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant