Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nsenter a configurable option #899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make nsenter a configurable option #899

wants to merge 1 commit into from

Conversation

bh185140
Copy link

@bh185140 bh185140 commented Feb 15, 2024 •
edited

Closes #896

@bh185140
Make nsenter an optional command
acceffb 
Signed-off-by: Benjamin Hodges <bh185140@ncr.com>
ckotzbauer
ckotzbauer reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I think I would prefer a flag if nsenter should be included or not. These changes here give us more flexibility, but it is also more complicated to configure it correctly.
@jackfrancis WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckotzbauer ckotzbauer ckotzbauer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make nsenter in reboot command optional
2 participants
@bh185140 @ckotzbauer