From 55fed9eb50f948b7fa5dd7df4b14e4026000a170 Mon Sep 17 00:00:00 2001 From: moelsayed Date: Thu, 14 Mar 2024 06:25:26 +0100 Subject: [PATCH] improve errors --- .../api/pkg/ee/clusterbackup/storage-location/provider.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/api/pkg/ee/clusterbackup/storage-location/provider.go b/modules/api/pkg/ee/clusterbackup/storage-location/provider.go index 631699bbe3..23eb13ab01 100644 --- a/modules/api/pkg/ee/clusterbackup/storage-location/provider.go +++ b/modules/api/pkg/ee/clusterbackup/storage-location/provider.go @@ -30,10 +30,12 @@ import ( "fmt" apiv2 "k8c.io/dashboard/v2/pkg/api/v2" + "k8c.io/dashboard/v2/pkg/handler/v1/common" "k8c.io/dashboard/v2/pkg/provider" "k8c.io/dashboard/v2/pkg/provider/kubernetes" kubermaticv1 "k8c.io/kubermatic/v2/pkg/apis/kubermatic/v1" "k8c.io/kubermatic/v2/pkg/resources" + utilerrors "k8c.io/kubermatic/v2/pkg/util/errors" corev1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" @@ -97,7 +99,7 @@ func (p *BackupStorageProvider) Get(ctx context.Context, userInfo *provider.User return &cbsl, nil } } - return nil, nil + return nil, utilerrors.NewNotFound("ClusterBackupStorageLocation", name) } func (p *BackupStorageProvider) Create(ctx context.Context, userInfo *provider.UserInfo, cbslName, projectID string, cbsl *kubermaticv1.ClusterBackupStorageLocation, credentials apiv2.S3BackupCredentials) (*kubermaticv1.ClusterBackupStorageLocation, error) { @@ -140,7 +142,7 @@ func (p *BackupStorageProvider) Create(ctx context.Context, userInfo *provider.U Key: "cloud-credentials", } if err := client.Create(ctx, cbsl); err != nil { - return nil, err + return nil, common.KubernetesErrorToHTTPError(err) } ownerReference := metav1.OwnerReference{ APIVersion: ownerReferenceApi,