Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed and Master MLA customization uses outdated format #1126

Open
almereyda opened this issue Aug 3, 2022 · 17 comments
Open

Seed and Master MLA customization uses outdated format #1126

almereyda opened this issue Aug 3, 2022 · 17 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@almereyda
Copy link
Contributor

almereyda commented Aug 3, 2022

In the current documentation for customizing seed cluster MLAs

the "Customer-Cluster" (this is called User Cluster everywhere else) Prometheus is configured through a kubermatic.clusterNamespacePrometheus key, that is supposedly present in the seed's YAML.

Unfortunately that Key was only available and documented until v2.14,

but is still mentioned in the documentation. As the keys are only offered through

which appear very similar to those used in

is it possible to reuse that key clusterNamespacePrometheus in the Seed spec to configure the userNamespacePrometheuses?

While the old installer repository is full of references to it:

the new one doesn't know it anymore, and I am unsure where to put custom scraping rules for Prometheus for the user cluster MLA stack, and how to make sure that they propagate to the User Cluster MLA instances, esp. Prometheus here.

It appears this is nowadays done through the monitoring key in the configuration manifest, but remains undocumented:

It appears this is partly related to

@almereyda
Copy link
Contributor Author

Another way to bring in scraping configs, as do the kube-state-metrics and node-exporter plugins, seems to be through providing prometheus-scraping-* configmaps into the mla-system namespace.

apiVersion: v1
kind: ConfigMap
metadata:
  name: prometheus-scraping-postgres-operator
  namespace: mla-system
data:
  custom-scrape-configs.yaml: |
    ...

where we can add a similar YAML-formatted string as in the manifest.

@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2022
@kubermatic-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubermatic-bot kubermatic-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 2, 2022
@kubermatic-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubermatic-bot
Copy link
Contributor

@kubermatic-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik
Copy link
Member

embik commented Jan 19, 2023

/reopen
/remove-lifecycle rotten

@kubermatic-bot
Copy link
Contributor

@embik: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale. label Jan 19, 2023
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2023
@embik
Copy link
Member

embik commented Apr 24, 2023

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2023
@embik
Copy link
Member

embik commented Apr 24, 2023

@wurbanski can you maybe take a look at this if you have time and see what we need to fix and if it's still true?

@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2023
@embik
Copy link
Member

embik commented Jul 25, 2023

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2023
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2023
@embik
Copy link
Member

embik commented Oct 23, 2023

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2023
@wurbanski wurbanski self-assigned this Oct 23, 2023
@wurbanski
Copy link
Contributor

@embik this is the first time I see this 👀 will take a look

@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@embik
Copy link
Member

embik commented Jan 22, 2024

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@embik embik added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants