Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sync-client #5432

Merged
merged 1 commit into from Dec 15, 2022
Merged

Conversation

hdurand0710
Copy link
Contributor

@hdurand0710 hdurand0710 commented Dec 15, 2022

Signed-off-by: Helene Durand helene@kubermatic.com

What this PR does / why we need it:
With the move of the API from KKP to dashboard, the go client generation was removed from kkp post-submits job and not added to the dashboard repo (https://github.com/kubermatic/infra/pull/1937)
This PR adds the sync script in dashboard and a infra PR is also raised for the prow job (https://github.com/kubermatic/infra/pull/1999)

Which issue(s) this PR fixes:

Fixes kubermatic/go-kubermatic#5

What type of PR is this?

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2022
Signed-off-by: Helene Durand <helene@kubermatic.com>
@pkprzekwas
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f56a595bbd3b354a6b4c1a8d04107ad9d05bcd5

@pkprzekwas
Copy link
Contributor

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hdurand0710, pkprzekwas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@kubermatic-bot kubermatic-bot merged commit c65e523 into kubermatic:main Dec 15, 2022
@hdurand0710 hdurand0710 deleted the 5-sync-go-client branch December 16, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api Denotes a PR or issue as being assigned to SIG API. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code generation is broken after the move of API to dashboard repository
3 participants