Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using gopkg.in/yaml.v3 package for marshaling YAML #586

Closed
xmudrii opened this issue Jul 15, 2019 · 3 comments
Closed

Consider using gopkg.in/yaml.v3 package for marshaling YAML #586

xmudrii opened this issue Jul 15, 2019 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important
Milestone
v0.11

Comments

@xmudrii
Copy link
Member

xmudrii commented Jul 15, 2019 •
edited

We should consider using the gopkg.in/yaml.v3 package for marshaling YAML. Currently, we're using gopkg.in/yaml.v2, but v3 is compatible with Go modules and brings some new features, such as marshaling YAML with comments.
@xmudrii xmudrii added kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important labels Jul 15, 2019
@xmudrii xmudrii added this to the v0.10 milestone Jul 15, 2019
@xmudrii xmudrii changed the title Consider moving to gopkg.in/yaml.v3 package for parsing YAML Consider using gopkg.in/yaml.v3 package for parsing YAML Jul 15, 2019
@xmudrii xmudrii changed the title Consider using gopkg.in/yaml.v3 package for parsing YAML Consider using gopkg.in/yaml.v3 package for marshaling YAML Jul 15, 2019
@xmudrii xmudrii modified the milestones: v0.10, v0.11 Jul 24, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Sep 30, 2019

There are also upstream discussions for moving to yaml.v3:

@xmudrii
Copy link
Member Author

xmudrii commented Oct 15, 2019

/close

There are some problems with yaml.v3 and it doesn't make sense to migrate now.

@kubermatic-bot
Copy link
Contributor

@xmudrii: Closing this issue.

In response to this:

/close

There are some problems with yaml.v3 and it doesn't make sense to migrate now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important
Projects
None yet
Milestone
v0.11
Development

No branches or pull requests
2 participants
@xmudrii @kubermatic-bot