From f1162ad83c408ba4d6ddad8b7863bbdec274a117 Mon Sep 17 00:00:00 2001 From: Simon Bein Date: Wed, 13 Mar 2024 15:36:42 +0100 Subject: [PATCH] review comments Signed-off-by: Simon Bein --- pkg/controller/operator/common/util.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/controller/operator/common/util.go b/pkg/controller/operator/common/util.go index 140b8947bf..810ae00fd3 100644 --- a/pkg/controller/operator/common/util.go +++ b/pkg/controller/operator/common/util.go @@ -190,9 +190,12 @@ func VersionLabelModifierFactory(version string) reconciling.ObjectModifier { deployment, ok := obj.(*appsv1.Deployment) if !ok { - return obj, nil + return obj, fmt.Errorf("VersionLabelModifier is only implemented for deployments, not %T", obj) } + if deployment.ObjectMeta.Labels == nil { + deployment.ObjectMeta.Labels = make(map[string]string) + } deployment.ObjectMeta.Labels[resources.VersionLabel] = version deployment.Spec.Template.Labels[resources.VersionLabel] = version