Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking E2E tests for Machine Controller to support external CCM #1626

Open
ahmedwaleedmalik opened this issue May 3, 2023 · 7 comments
Open
Labels
kind/chore Updating grunt tasks etc; no production code changes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/high

Comments

@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented May 3, 2023

Kubernetes maintainers have long been discouraging the usage of In-tree cloud controller manager(CCM) in favor of external CCM. In-tree providers are planned to be removed from the Kubernetes core and we are already affected with:

  • OpenStack on k8s v1.26+
  • AWS on k8s v1.27+

For now, we are ignoring or skipping e2e tests for the affected versions but this is not ideal/acceptable, it's important to ensure that the e2e tests are reliable and up-to-date.

Proposed solution

Switch from KIND to KKP for machine-controller E2E tests.

  1. Create a dedicated KKP setup(or dedicated seed) for machine-controller. Connectivity for nodes would work out of the box and we won't need any hacks for CCM or CNI.
  2. Creating user clusters for e2e tests. We have multiple options for that; we should evaluate and choose:
    1. Long-standing user clusters per cloud provider with no machine deployments. MC will create the required machine deployments for tests and then clean them up.
    2. When running tests, create a user cluster per cloud provider. We can check if a user cluster for the provider already exists and then just use it.
    3. Dedicated user cluster per CI job; this is not ideal due to resource constraints and the cost incurred.
  3. Run our test suite to check that the machine came up and was ready. We don't need conformance tests etc. here.

This would help solve #1462 as well.

NOTE: Proper cleanup jobs should be in place right from the start to avoid broken/cancelled jobs leading to orphaned resources

Alternate solution

  • Stick to KIND and deploy external CCM for each cloud provider when it's required
  • Create single node clusters using KubeOne to run the tests
@ahmedwaleedmalik ahmedwaleedmalik added priority/high kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/chore Updating grunt tasks etc; no production code changes. labels May 3, 2023
@embik
Copy link
Member

embik commented May 3, 2023

Will also fix #1620.

@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2023
@ahmedwaleedmalik
Copy link
Member Author

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2023
@ahmedwaleedmalik
Copy link
Member Author

With #1709, we are dropping support for Kubernetes 1.25 and that makes the e2e tests for OpenStack no-op. Since they require external CCM.

@ahmedwaleedmalik
Copy link
Member Author

In-tree providers have been disabled by default via kubernetes/kubernetes#117503.

@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2024
@embik
Copy link
Member

embik commented Apr 7, 2024

/remove-lifecycle stale

@kubermatic-bot kubermatic-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2024
@embik embik added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Updating grunt tasks etc; no production code changes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/high
Projects
None yet
Development

No branches or pull requests

3 participants