Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose metrics for MachineDeployment status #1767

Open
embik opened this issue Feb 26, 2024 · 2 comments
Open

Expose metrics for MachineDeployment status #1767

embik opened this issue Feb 26, 2024 · 2 comments
Labels
customer-request kind/feature Categorizes issue or PR as related to a new feature.

Comments

@embik
Copy link
Member

embik commented Feb 26, 2024

We need metrics to track MachineDeployments managed by this machine-controller over time. Primarily, the MachineDeployments' status information wrapped in metrics would be helpful, so something like:

  • machine_deployment_available_replicas
  • machine_deployment_ready_replicas
  • machine_deployment_replicas
  • machine_deployment_updated_replicas

With these metrics, alerts could be defined that e.g. alert on machine_deployment_replicas > machine_deployment_updated_replicas being true for more than 30 minutes (random example here).

@embik embik added customer-request kind/feature Categorizes issue or PR as related to a new feature. labels Feb 26, 2024
@adberger
Copy link

adberger commented Apr 6, 2024

@embik
Copy link
Member Author

embik commented Apr 6, 2024

For this use case https://github.com/kubernetes/kube-state-metrics/blob/main/docs/metrics/extend/customresourcestate-metrics.md could be enough?

That's definitely a way to implement metrics for these values if you need them, thank you for bringing up this option. At best, we expose those natively in future releases, but if you (as in you stumbled over this issue because you are missing those metrics) need this asap, the CRD solution from kube-state-metrics should help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-request kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants